[asterisk-dev] [Code Review] 4261: res_pjsip_pubsub: Activate recreated persistent subscriptions

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4261/
-----------------------------------------------------------

(Updated Dec. 15, 2014, 9:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 429571


Repository: Asterisk


Description
-------

Persistent subscriptions are recreated successfully, but the subscription handlers (e.g. MWI) do not know that the persistent subscription was recreated. This is because the subscription_established() callback is not called for the handler when a persistent subscription is recreated. This patch corrects this by generating the "initial" NOTIFY request when a persistent subscription is recreated.

This issue only affects Asterisk 13 since the bug was introduced when 13's pubsub framework was refactored.


Diffs
-----

  /branches/13/res/res_pjsip_pubsub.c 429063 

Diff: https://reviewboard.asterisk.org/r/4261/diff/


Testing
-------

Before the patch, starting Asterisk with a persistent subscription would result in a NULL-state subscription being shown by PJSIPShowSubscriptionsInbound. Trying to update state on the subscription would not result in NOTIFY requests being sent out on the subscription. After the patch, starting Asterisk with a persistent subscription results in an ACTIVE-state subscription being shown by PJSIPShowSubscriptionsInbound. Trying to update state on the subscription results in NOTIFY requests being sent.


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141215/f43d7f4a/attachment.html>