[asterisk-dev] [Code Review] 4257: chan_pjsip: Race condition between channel answer and bridge setup when using direct media

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4257/
-----------------------------------------------------------

(Updated Dec. 12, 2014, 9:30 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 429477


Bugs: ASTERISK-24563
    https://issues.asterisk.org/jira/browse/ASTERISK-24563


Repository: Asterisk


Description
-------

When direct media is enabled and a pjsip channel is answered a race would occur between the handling of the answer and bridge setup. Sometimes the media negotiation would take place after the native bridge was setup.  This resulted in a NULL media address, which in turn resulted in Asterisk using its address as the remote media address when sending a reinvite.  This patch makes the chan_pjsip answer handler synchronous thus alleviating the race condition (the bridge won't start setting things up until after it returns).


Diffs
-----

  branches/13/channels/chan_pjsip.c 429386 

Diff: https://reviewboard.asterisk.org/r/4257/diff/


Testing
-------

Made around 100 phones calls with and did not issue occur again.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141212/d7dd50d4/attachment.html>