[asterisk-dev] [Code Review] 4251: loader: Move definition of ast_module_reload from _private.h to module.h

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4251/#review13952
-----------------------------------------------------------

Ship it!


I'm totally fine with this.

- Mark Michelson


On Dec. 10, 2014, 10:42 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4251/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 10:42 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> No functionality change.  Just move the definition of ast_module_reload from _private.h to module.h so it can be public.
> 
> Also removed the include of _private.h from manager.c since ast_module_load was the only reason for including it.
> 
> 
> Diffs
> -----
> 
>   branches/13/main/manager.c 429349 
>   branches/13/include/asterisk/module.h 429349 
>   branches/13/include/asterisk/_private.h 429349 
> 
> Diff: https://reviewboard.asterisk.org/r/4251/diff/
> 
> 
> Testing
> -------
> 
> Compile's fine.
> Tested cli reload commands and all still reload as they should.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141211/0b0a88b5/attachment-0001.html>