[asterisk-dev] [Code Review] 4258: Fix crash for sorcery misconfigs

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4258/#review13947
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Dec. 11, 2014, 7:59 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4258/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 7:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> res_pjsip_outbound_publish was missing the CHECK_PJSIP_MODULE_LOADED()
> call in load_module, and would crash with a segfault if res_pjsip
> declined to load.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_pjsip_outbound_publish.c 429386 
> 
> Diff: https://reviewboard.asterisk.org/r/4258/diff/
> 
> 
> Testing
> -------
> 
> Added res_pjsip realtime config to sorcery.conf (see https://wiki.asterisk.org/wiki/x/wgaUAQ) without configuring extconfig.conf. Asterisk crashes on startup.
> 
> Applied patch, build, install, start Asterisk, no crash.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141211/bf35a997/attachment-0001.html>