[asterisk-dev] [Code Review] 4252: PJSIP: Allow use of 'inactive' stream types for hold

Joshua Colp reviewboard at asterisk.org
Thu Dec 11 12:21:58 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4252/#review13942
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Dec. 11, 2014, 4:43 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4252/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 4:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This allows use of the 'inactive' stream direction identifier to be used for hold where 'sendonly' is normally used. Some seimens phones use 'inactive' and this change allows music on hold to operate properly.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_sdp_rtp.c 429324 
> 
> Diff: https://reviewboard.asterisk.org/r/4252/diff/
> 
> 
> Testing
> -------
> 
> Ran existing pjsip tests in the testsuite and created new tests for checking functionality of the 'inactive' stream direction.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141211/304150cb/attachment.html>


More information about the asterisk-dev mailing list