[asterisk-dev] [Code Review] 4254: res_pjsip_session: Don't allow declined media streams to fail SDP negotiation on re-INVITE

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4254/#review13939
-----------------------------------------------------------

Ship it!


Other than adjusting the comment below, this looks good to go.


/branches/12/res/res_pjsip_session.c
<https://reviewboard.asterisk.org/r/4254/#comment24472>

    This comment needs tweaking.


- opticron


On Dec. 11, 2014, 11:01 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4254/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 11:01 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24607
>     https://issues.asterisk.org/jira/browse/ASTERISK-24607
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> On an initial incoming INVITE declined streams are not treated as a fatal SDP negotiation error. On a re-INVITE, however, they are treated as fatal. The behavior should be the same between the two of them.
> 
> This change makes it so the behavior is.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_session.c 429377 
> 
> Diff: https://reviewboard.asterisk.org/r/4254/diff/
> 
> 
> Testing
> -------
> 
> Ran test. Before patch it failed, with patch it worked. I also ran the existing SDP offer/answer tests to make sure they continued to work as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141211/41b0c9c2/attachment.html>