[asterisk-dev] [Code Review] 4246: PJSIP: Stagger outbound qualifies

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4246/#review13928
-----------------------------------------------------------



branches/12/CHANGES
<https://reviewboard.asterisk.org/r/4246/#comment24450>

    As much as I'm a fan of making sure the CHANGES field is updated... are we sure this warrants end user attention?
    
    Really, we're kind of fixing a 'packet storm' bug here. Things that belong in CHANGES are those where either:
    * The user has a new configuration option/schema change/etc. to worry about
    * Behaviour the user would have counted on has now changed
    
    I'm not sure this fits into either category.


- Matt Jordan


On Dec. 8, 2014, 1:16 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4246/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 1:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24342
>     https://issues.asterisk.org/jira/browse/ASTERISK-24342
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change staggers initiation of outbound qualify (OPTIONS) attempts to reduce instantaneous server load and prevent network congestion.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip/pjsip_options.c 429060 
>   branches/12/CHANGES 429060 
> 
> Diff: https://reviewboard.asterisk.org/r/4246/diff/
> 
> 
> Testing
> -------
> 
> Verified that this did not break the existing qualify test and used wireshark to verify that the OPTIONS messages were being sent at staggered intervals with the patch and all at once without the patch.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141208/7b34ee89/attachment-0001.html>