[asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4243/#review13910
-----------------------------------------------------------



/branches/13/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4243/#comment24419>

    Should only have one variable declaration per line.



/branches/13/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4243/#comment24420>

    Heh.  This doesn't match what the last sentence in the review description is saying.


- rmudgett


On Dec. 5, 2014, 3:10 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4243/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 3:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24552
>     https://issues.asterisk.org/jira/browse/ASTERISK-24552
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently when originating a call using ARI there is no way to specify an association of who is triggering the outbound dial. This is normally visible through the LinkedID. To allow this association to be present I've added the ability to specify the unique id of the channel doing the origination. If the channel exists on the system it will be examined and the linked id from it used. If the channel does not exist the provided originator unique id will be used as the linked id.
> 
> 
> Diffs
> -----
> 
>   /branches/13/rest-api/api-docs/channels.json 429026 
>   /branches/13/res/res_ari_channels.c 429026 
>   /branches/13/res/ari/resource_channels.c 429026 
>   /branches/13/res/ari/resource_channels.h 429026 
> 
> Diff: https://reviewboard.asterisk.org/r/4243/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing ARI origination tests and confirmed they still pass.
> Performed calls manually and examined the resulting channels and CEL log to ensure they contain the linked ID of the originator.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141205/aa5ef019/attachment-0001.html>