[asterisk-dev] [Code Review] 4242: app_meetme: Fix default values initialization when no configuration file is present

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4242/#review13904
-----------------------------------------------------------



trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/4242/#comment24415>

    At this point call the set defaults routine if not a reload so defaults always get set on initial module load.



trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/4242/#comment24416>

    At this point call the set defaults routine if reload so defaults get set only if the config gets reloaded.



trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/4242/#comment24413>

    Put the code setting the defaults in its own function and call.
    
    The defaults need to be set in load_config_meetme() before calling ast_config_load() if not a reload.
    The defaults need to be set in load_config_meetme() after calling ast_config_load() if a reload.
    



trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/4242/#comment24414>

    Pass reload to load_config_meetme() so it can determine when it needs to set defaults.


- rmudgett


On Dec. 5, 2014, 10:10 a.m., nerbos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4242/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 10:10 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: https://issues.asterisk.org/jira/browse/ASTERISK-24572
>     https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-24572
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When the app_meetme module is loaded without its configuration file, the module settings aren't initialized. This patch guarantees that we always load the module default settings.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_meetme.c 428998 
> 
> Diff: https://reviewboard.asterisk.org/r/4242/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nerbos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141205/ba2b1dc7/attachment-0001.html>