[asterisk-dev] [Code Review] 4231: New AMI/ARI events for connected line updates on a channel

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4231/#review13889
-----------------------------------------------------------



/branches/13/main/manager_channels.c
<https://reviewboard.asterisk.org/r/4231/#comment24402>

    NewCallerid?
    How about NewConnectedLine instead. :)


- rmudgett


On Dec. 4, 2014, 11:07 a.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4231/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 11:07 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24554
>     https://issues.asterisk.org/jira/browse/ASTERISK-24554
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently, there is an event that occurs when Caller ID on a channel changes (NewCallerid for AMI, ChannelCallerId for ARI). This change implements a similar event when a channel's connected line changes (NewConnectedLine for AMI, ChannelConnectedLine for ARI).
> 
> This change is proposed for Asterisk 13 since it is not very invasive and has accompanying tests.
> 
> 
> Diffs
> -----
> 
>   /branches/13/rest-api/api-docs/events.json 428835 
>   /branches/13/res/stasis/app.c 428835 
>   /branches/13/res/ari/ari_model_validators.c 428835 
>   /branches/13/res/ari/ari_model_validators.h 428835 
>   /branches/13/main/stasis_channels.c 428835 
>   /branches/13/main/manager_channels.c 428835 
>   /branches/13/main/channel.c 428835 
>   /branches/13/include/asterisk/stasis_channels.h 428835 
>   /branches/13/CHANGES 428835 
> 
> Diff: https://reviewboard.asterisk.org/r/4231/diff/
> 
> 
> Testing
> -------
> 
> See /r/4232 for some automated tests.
> 
> I also performed calls between multiple parties to ensure that in typical bridging scenarios, the events were emitted.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141204/1cf1a885/attachment.html>