[asterisk-dev] reviewboard gives 500 error

[Matthew Jordan]

On Wed, Dec 3, 2014 at 3:58 PM, Matthew Jordan <mjordan at digium.com> wrote:
> On Wed, Dec 3, 2014 at 3:54 PM, James Cloos <cloos at jhcloos.com> wrote:
>> My attempts to start a review of my patch on bug 24575 fail with a 500
>> error.
>>
>> I do not see anywhere in jira or on the reviewboard site to submit a bug
>> report about https://reviewboard.asterisk.org/, so I am posting here.
>>
>> -JimC
>> --
>> James Cloos <cloos at jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6
>>
>
> Did you sign a license contributor agreement?

Heh - I should have checked the 'something has gone wrong' folder
prior to responding.

Your diff appears to be invalid, per the exception being thrown by Review Board:

Traceback (most recent call last):

  File "/usr/local/lib/python2.7/
dist-packages/Django-1.4.8-py2.7.egg/django/core/handlers/base.py",
line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.21-py2.7.egg/djblets/auth/util.py",
line 47, in _checklogin
    return view_func(request, *args, **kwargs)

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/reviews/views.py",
line 249, in new_review_request
    local_site=local_site)

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/reviews/forms.py",
line 256, in create
    attach_to_history=True)

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/reviews/forms.py",
line 309, in create
    history)

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/diffviewer/forms.py",
line 67, in create
    request=self.request)

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/diffviewer/managers.py",
line 82, in create_from_upload
    save=save)

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/diffviewer/managers.py",
line 103, in create_from_data
    check_existence=(not parent_diff_file_contents)))

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/diffviewer/managers.py",
line 190, in _process_files
    for f in parser.parse():

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/diffviewer/parser.py",
line 51, in parse
    next_linenum, new_file = self.parse_change_header(i)

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/diffviewer/parser.py",
line 83, in parse_change_header
    linenum = self.parse_diff_header(linenum, info)

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/scmtools/svn.py",
line 514, in parse_diff_header
    return super(SVNDiffParser, self).parse_diff_header(linenum, info)

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/diffviewer/parser.py",
line 157, in parse_diff_header
    linenum)

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.16.dev-py2.7.egg/reviewboard/diffviewer/parser.py",
line 194, in parse_filename_header
    linenum)

DiffParserError: No valid separator after the filename was found in
the diff header


You may want to consider using RBTools to make this process easier:

https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage


-- 
Matthew Jordan
Digium, Inc. | Engineering Manager
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org