[asterisk-dev] [Code Review] 4212: res_pjsip_endpoint_identified_ip: Add 'show identify' and 'show identifies' cli commands

Joshua Colp reviewboard at asterisk.org
Mon Dec 1 05:37:16 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4212/#review13849
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Nov. 24, 2014, 7:35 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4212/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 7:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> While troubleshooting other things I realized there were no pjsip cli commands for identify.  This patch adds them.  It also also fixes a reference leak when a 'show endpoint' displayed identifies and properly sets the return code if load_module can't allocate a cli formatter structure.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 428600 
>   branches/12/res/res_pjsip/pjsip_cli.c 428600 
> 
> Diff: https://reviewboard.asterisk.org/r/4212/diff/
> 
> 
> Testing
> -------
> 
> Made sure the cli commands produce the expected output.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141201/f6d635b9/attachment.html>


More information about the asterisk-dev mailing list