[asterisk-dev] [Code Review] 3958: manager: Make WaitEvent action respect eventfilters

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3958/#review13205
-----------------------------------------------------------

Ship it!


This applies to v1.8+

- rmudgett


On Aug. 28, 2014, 4:11 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3958/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 4:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A WaitEvent issued via an http session isn't respecting eventfilters defined for the user. I just added a match_filter to the predicate that controls astman_append.
> 
> 
> Diffs
> -----
> 
>   branches/12/main/manager.c 422277 
> 
> Diff: https://reviewboard.asterisk.org/r/3958/diff/
> 
> 
> Testing
> -------
> 
> Verified that events to be filtered are indeed filtered and that events not supposed to be filtered aren't.
> 
> I ran the manager TestSuite but 4 of 9 tests failed BEFORE my change.  The same 4 failed after my change.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140829/b212b414/attachment.html>