[asterisk-dev] [Code Review] 3960: res_pjsip_pubsub: Check supported headers for eventlist before allowing subscribe to resource list

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3960/
-----------------------------------------------------------

(Updated Aug. 28, 2014, 5:49 p.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Address mmichelson's findings


Bugs: ASTERISK-23871
    https://issues.asterisk.org/jira/browse/ASTERISK-23871


Repository: Asterisk


Description
-------

https://wiki.asterisk.org/wiki/display/AST/Resource+List+Subscription+Test+Plan

According to the off-nominal plan, if eventlist support is indicated in a subscribe's Supported header(s), subscriptions to a resource list should fail with a 421 extension not supported. This wasn't currently happening since the Supported header isn't actually checked by anything in the res_pjsip_pubsub code, so this patch adds a check for it.


Diffs (updated)
-----

  /branches/13/res/res_pjsip_pubsub.c 422272 

Diff: https://reviewboard.asterisk.org/r/3960/diff/


Testing
-------

Ran nominal RLS tests, ran in development off-nominal RLS tests, and ran Presence and MWI PJSIP subscription tests to confirm that they didn't break.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140828/d529383a/attachment.html>