[asterisk-dev] [Code Review] 3950: confbridge: Add 'Admin' parameter to join, leave, mute, unmute and talking events

George Joseph reviewboard at asterisk.org
Wed Aug 27 11:56:38 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3950/
-----------------------------------------------------------

(Updated Aug. 27, 2014, 10:56 a.m.)


Review request for Asterisk Developers and rmudgett.


Changes
-------

Addressed Richard's comments.


Repository: Asterisk


Description
-------

Currently there's no way to tell if a user is an admin or not when receiving the join, leave, mute, unmute and talking events.  This patch adds that capability.


Diffs (updated)
-----

  branches/12/apps/confbridge/confbridge_manager.c 422175 
  branches/12/apps/app_confbridge.c 422175 

Diff: https://reviewboard.asterisk.org/r/3950/diff/


Testing
-------

Checked that the AMI events had properly set Admin flags.

All of the 11 eligible TestSuite confbridge tests passed although they don't test for the existence of the new flag yet.  Nothing broke at least.


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140827/e5042b01/attachment.html>


More information about the asterisk-dev mailing list