[asterisk-dev] [Code Review] 3949: a separate output-dir option

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3949/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: testsuite


Description
-------

This is a preliminary patch and I don't expect it to be included in the test suite as-is. However I welcome any ideas on generalising it so I could avoid including it.

I package the test suite in Debian in order to be able to run tests on Asterisk ci.debian.org (and wherever). Including the test suite within the Asterisk package itself didn't look as a good alternative: I should be able to update it independenly of Asterisk, and such huge extra sources don't look good.

Running the test suite on an installed version of Asterisk works well (and the test driver makes it trivially easy to run tests in a separate container. Of any type). However the test suite likes to write into the same directory structure as the one of the tests. The tests are a large collection of architecture-independent files[1] and thus all belong under /usr/share . But the test results[2] seem to be basically two things:

1. the logs directory
2. The results XML file

I started writing a patch that redirects both of them to a structure under /var/lib/asterisk-testsuite (maybe /var/log would have been better). Redirecting the XML file was very simple. I started trying to figure out how to redirect the logs, and noticed that there are too many references to them. But then noticed that it would be simpler for me to redirect the logs directory at install time using a symlink.

So: anybody else needs such a patch? If so: is it useful without redirecting the logs?

BTW: the wrapper I use to run the tests:

#!/bin/sh
cd /usr/share/asterisk-testsuite
exec ./runtests.py -o "/var/lib/asterisk-testsuite" "$@"


[1] besides asttest. I have it in a separate binary package. It seems it is still needed.
[2] Ignoring /tmp/asterisk-testsuite - a permanent path under /tmp. I really hope noone shouts at me for that.


Diffs
-----

  /asterisk/trunk/runtests.py 5520 

Diff: https://reviewboard.asterisk.org/r/3949/diff/


Testing
-------


Thanks,

Tzafrir Cohen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140826/67e0acbc/attachment.html>