[asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3944/#review13176
-----------------------------------------------------------


I don't think a mute/unmute all feature was intended when the kick all feature was added.  The mute/unmute commands call the same completion routine and thus unintentionally got the all added to the list.

However, you might want to make the "mute/unmute all" set the mute only on non-admin users.  Otherwise the conference would be rather dull with everyone muted.


branches/12/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/3944/#comment23640>

    This is set but not used since it is set to -2 by the next use.


- rmudgett


On Aug. 25, 2014, 4:43 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3944/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 4:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Although tab completion for confbridge mute and unmute show 'all' as a valid channel target, it was never implemented.
> 
> This patch updates mute and unmute (both CLI and AMI) to allow the 'all' target.  They now work as kick does.  Since I was there, I made the channel name case-insensitive since kick was already case-insensitive.
> 
> 
> Diffs
> -----
> 
>   branches/12/apps/app_confbridge.c 422052 
> 
> Diff: https://reviewboard.asterisk.org/r/3944/diff/
> 
> 
> Testing
> -------
> 
> Tested that both CLI and AMI handle 'all' as a channel target for mute and unmute correctly.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140825/cb390653/attachment.html>