[asterisk-dev] [Code Review] 3928: res_musiconhold: Fix MOH restarting where it left off from the last hold.

[rmudgett]

> On Aug. 24, 2014, 11:20 a.m., wdoekes wrote:
> > /branches/1.8/res/res_musiconhold.c, line 421
> > <https://reviewboard.asterisk.org/r/3928/diff/1/?file=66739#file66739line421>
> >
> >     Something like this?
> >     
> >     /* If the class has the same name and amount of files, continue where we left off. If not, reset state. */

That isn't a good comment as it just restates the code.  I'll add a comment giving the why.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3928/#review13159
-----------------------------------------------------------


On Aug. 22, 2014, 5:25 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3928/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 5:25 p.m.)
> 
> 
> Review request for Asterisk Developers and wdoekes.
> 
> 
> Bugs: ASTERISK-24019
>     https://issues.asterisk.org/jira/browse/ASTERISK-24019
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Restore code removed by https://reviewboard.asterisk.org/r/3536/ that introduced a regression that prevents MOH from restarting were it left off the last time.
> 
> I think the previous change removed the code because there was an incorrect comment that indicated the dereferencing of a stale MOH class pointer.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/res/res_musiconhold.c 421902 
> 
> Diff: https://reviewboard.asterisk.org/r/3928/diff/
> 
> 
> Testing
> -------
> 
> Establish a call between two parties and place one party on and off hold several times.
> MOH resumes where it left off from the last hold.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140825/f1f0b04e/attachment.html>