[asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3923/
-----------------------------------------------------------

(Updated Aug. 25, 2014, 8:52 a.m.)


Review request for Asterisk Developers.


Changes
-------

Address Richard's comments.


Repository: Asterisk


Description
-------

This allows the callerid parsing function to handle malformed input strings and strings containing escaped and unescaped double quotes. This also adds a unittest to cover many of the cases where the parsing algorithm previously failed.


Diffs (updated)
-----

  branches/1.8/tests/test_utils.c 421534 
  branches/1.8/tests/test_callerid.c PRE-CREATION 
  branches/1.8/main/utils.c 421534 
  branches/1.8/main/callerid.c 421534 
  branches/1.8/include/asterisk/utils.h 421534 
  branches/1.8/channels/chan_sip.c 421534 

Diff: https://reviewboard.asterisk.org/r/3923/diff/


Testing
-------

Ran the unittest.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140825/598ef182/attachment.html>