[asterisk-dev] [Code Review] 3911: testsuite: Tests hangup during ari playback to a channel in a bridge
Matt Jordan
reviewboard at asterisk.org
Thu Aug 21 13:07:30 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3911/#review13146
-----------------------------------------------------------
Ship it!
/asterisk/trunk/tests/rest_api/channels/playback/to_channel_in_bridge_hangup/test-config.yaml
<https://reviewboard.asterisk.org/r/3911/#comment23604>
Throw res_ari_bridges here as well
/asterisk/trunk/tests/rest_api/channels/playback/to_channel_in_bridge_hangup/test-config.yaml
<https://reviewboard.asterisk.org/r/3911/#comment23605>
Put a new line at the end of the file for kindness.
- Matt Jordan
On Aug. 21, 2014, 1 p.m., Jonathan Rose wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3911/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 1 p.m.)
>
>
> Review request for Asterisk Developers, kmoore, Matt Jordan, and Mark Michelson.
>
>
> Bugs: ASTERISK-24147
> https://issues.asterisk.org/jira/browse/ASTERISK-24147
>
>
> Repository: testsuite
>
>
> Description
> -------
>
> Specifically made to address the crash in ASTERISK-24147. This is a modification of the existing test which checks playback in a bridge without hanging up with only the minor difference that a hangup is added and the test for the second playback finishing is removed.
>
>
> Diffs
> -----
>
> /asterisk/trunk/tests/rest_api/channels/playback/to_channel_in_bridge_hangup/test-config.yaml PRE-CREATION
> /asterisk/trunk/tests/rest_api/channels/playback/to_channel_in_bridge/test-config.yaml 5440
> /asterisk/trunk/tests/rest_api/channels/playback/tests.yaml 5440
>
> Diff: https://reviewboard.asterisk.org/r/3911/diff/
>
>
> Testing
> -------
>
> Tested with and without the patch in https://reviewboard.asterisk.org/r/3908/
>
> Without the patch, Asterisk crashes and the test fails.
> With the patch, the test is successful.
>
>
> Thanks,
>
> Jonathan Rose
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140821/3f2026a6/attachment-0001.html>
More information about the asterisk-dev
mailing list