[asterisk-dev] [Code Review] 3925: PJSIP: Use IP address in favor of hostname in SDP origin line.

[Mark Michelson]

> On Aug. 21, 2014, 7:04 a.m., wdoekes wrote:
> > > This changeset modifies the process by getting the hostname and then
> > > resolving that into an IP address. On my box, I could change the IP
> > > address by modifying my /etc/hosts file to resolve my hostname to a
> > > different IP address.
> > 
> > That's not going to work on many debian style boxes that have 127.0.1.1
> > as their IP. Which happens to be the default.
> > 
> > https://www.debian.org/doc/manuals/debian-reference/ch05.en.html#_the_hostname_resolution
> > 
> > Example:
> > 
> >   $ grep ns1.osso /etc/hosts
> >   127.0.1.1	ns1.osso.xx osso-ns1
> > 
> >   $ ping `hostname -f`
> >   PING ns1.osso.xx (127.0.1.1) 56(84) bytes of data.
> > 
> >   $ host `hostname -f`
> >   ns1.osso.xx has address 91.194.xx.xx
> > 
> >   
> > 
> > Is this going to be configurable somehow? Because 127.0.1.1 is worse
> > than my hostname.

Yes, it's configurable by changing /etc/hosts to not be 127.0.1.1 :)


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3925/#review13129
-----------------------------------------------------------


On Aug. 20, 2014, 11:06 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3925/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 11:06 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23994
>     https://issues.asterisk.org/jira/browse/ASTERISK-23994
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> From the issue, it was determined that using pj_gethostname() to populate the origin line of SDPs is not guaranteed to meet RFC 4566's requirement that the address be a FQDN or IP address. This changeset modifies the process by getting the hostname and then resolving that into an IP address. On my box, I could change the IP address by modifying my /etc/hosts file to resolve my hostname to a different IP address.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_session.c 421564 
> 
> Diff: https://reviewboard.asterisk.org/r/3925/diff/
> 
> 
> Testing
> -------
> 
> Placed an outbound call from Asterisk. I observed that the SDP origin line now contained an IP address instead of a hostname. When I modified /etc/hosts to resolve the hostname to a different IP address, that IP address appeared in the SDP origin line instead.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140821/3428e81b/attachment-0001.html>