[asterisk-dev] [Code Review] 1152: Access to any Exchange 2007 and 2010 calendar.

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1152/#review13127
-----------------------------------------------------------



/trunk/configs/samples/calendar.conf.sample
<https://reviewboard.asterisk.org/r/1152/#comment23584>

    ;mailbox
    
    spacing isn't uniform with the rest of this block. Also it looks like "; Primary SMTP address [...]" might be meant to have a line break. Line 79 runs a little long, so break it before the URL.
    
    Write casesensitive as 'case-sensitive' or 'case sensitive' (I think both are technically 



/trunk/configs/samples/calendar.conf.sample
<https://reviewboard.asterisk.org/r/1152/#comment23583>

    -folderpath= /meetingroom1
    +folderpath = /meetingroom1



/trunk/res/res_calendar_ews.c
<https://reviewboard.asterisk.org/r/1152/#comment23586>

    fflush appears to be misaligned by a tab.



/trunk/res/res_calendar_ews.c
<https://reviewboard.asterisk.org/r/1152/#comment23587>

    here too.



/trunk/res/res_calendar_ews.c
<https://reviewboard.asterisk.org/r/1152/#comment23582>

    You missed a spot :P



/trunk/res/res_calendar_ews.c
<https://reviewboard.asterisk.org/r/1152/#comment23585>

    There shouldn't be a blank line between XML docs and the function.


Aside from these style issues, this looks good to go to me. It'd be good to have someone with some experience with Exchange to take a look at it, but I don't believe that's a luxury we have.

- Jonathan Rose


On Aug. 20, 2014, 3:51 a.m., astmiv wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1152/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 3:51 a.m.)
> 
> 
> Review request for Asterisk Developers and pitlicek at gmail.com.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch will add access to any calendar folder within Exchange 2007 and 2010. 
> 
> The current resource only gives access to the default calendar folder of the specified user. With this patch it is possible to access any calendar folder within the system as long as the user has read rights to the folder and its complete folder path.
> 
> For example:
> - Calendar folders below the publicfoldersroot.
> - Calendar folders below the user's mailbox outside of his default calendar.
> - Calendar folders below the user's default calendar.
> - etc....
> 
> Also did some cleanup for XML schema labeling. They are now all the same.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_calendar_ews.c 421522 
>   /trunk/configs/samples/calendar.conf.sample 421522 
> 
> Diff: https://reviewboard.asterisk.org/r/1152/diff/
> 
> 
> Testing
> -------
> 
> Tested the following scenario's:
> - Access to default calendar of specified user. (folderbase not specified or folderbase=calendar)
> - Access to shared default calendar of other person. (mailbox=emailother at company.com and folderbase not specified or folderbase=calendar)
> - Access to calendar folder, named testfolder1, below default Calendar. (folderbase=calendar and folderpath=/testfolder1)
> - Access to calendar folder, named testfolder2, below a subfolder, named testfolder3, of the default Calendar. (folderbase=calendar and folderpath=/testfolder3/testfolder2)
> - Access to calendar folder in Public Folders. (folderbase=publicfoldersroot and folderpath=/meetingroom1)
> - Access to calendar folder below a subfolder in Public Folders. (folderbase=publicfoldersroot and folderpath=/meetingrooms/meetingroom1)
> - Access to calendar folder below mailbox of specified user. (folderbase=msgfolderroot and folderpath=/calendar2)
> 
> 
> Thanks,
> 
> astmiv
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140820/f7411e3e/attachment-0001.html>