[asterisk-dev] [Code Review] 1152: Access to any Exchange 2007 and 2010 calendar.

astmiv reviewboard at asterisk.org
Wed Aug 20 03:44:25 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1152/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 8:44 a.m.)


Review request for Asterisk Developers and pitlicek at gmail.com.


Changes
-------

Removed white space.
Added some inline comment (documentation) It is not the requested XML documentation as I do not have time for this at the moment.
Removed some duplicate memory cleanup and used goto and a variable to keep track of state.


Repository: Asterisk


Description
-------

This patch will add access to any calendar folder within Exchange 2007 and 2010. 

The current resource only gives access to the default calendar folder of the specified user. With this patch it is possible to access any calendar folder within the system as long as the user has read rights to the folder and its complete folder path.

For example:
- Calendar folders below the publicfoldersroot.
- Calendar folders below the user's mailbox outside of his default calendar.
- Calendar folders below the user's default calendar.
- etc....

Also did some cleanup for XML schema labeling. They are now all the same.


Diffs (updated)
-----

  /trunk/res/res_calendar_ews.c 311843 
  /trunk/configs/calendar.conf.sample 311843 

Diff: https://reviewboard.asterisk.org/r/1152/diff/


Testing
-------

Tested the following scenario's:
- Access to default calendar of specified user. (folderbase not specified or folderbase=calendar)
- Access to shared default calendar of other person. (mailbox=emailother at company.com and folderbase not specified or folderbase=calendar)
- Access to calendar folder, named testfolder1, below default Calendar. (folderbase=calendar and folderpath=/testfolder1)
- Access to calendar folder, named testfolder2, below a subfolder, named testfolder3, of the default Calendar. (folderbase=calendar and folderpath=/testfolder3/testfolder2)
- Access to calendar folder in Public Folders. (folderbase=publicfoldersroot and folderpath=/meetingroom1)
- Access to calendar folder below a subfolder in Public Folders. (folderbase=publicfoldersroot and folderpath=/meetingrooms/meetingroom1)
- Access to calendar folder below mailbox of specified user. (folderbase=msgfolderroot and folderpath=/calendar2)


Thanks,

astmiv

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140820/e85a121c/attachment.html>


More information about the asterisk-dev mailing list