[asterisk-dev] [Code Review] 3906: chan_pjsip: Update media translation paths when new SDP negotiated.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3906/#review13113
-----------------------------------------------------------

Ship it!


Ship It!

- opticron


On Aug. 13, 2014, 3 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3906/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 3 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AFS-137
>     https://issues.asterisk.org/jira/browse/AFS-137
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> On a SIP reinvite that changes media strams, the PJSIP channel driver was flooding the log with "Asked to transmit frame type %s, while native formats is %s" warnings.
> 
> * Fixes PJSIP not setting up translation paths when the formats change on a reinvite.
> 
> * Improved the unexpected frame format WARNING message to include more information.
> 
> * Added protective locking while altering formats on a channel.  Reworked set_format() to simplify and protect the formats under manipulation.
> 
> * Restored some code that got lost in the media_formats work.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_pjsip_sdp_rtp.c 420978 
>   /branches/13/main/file.c 420978 
>   /branches/13/main/channel.c 420978 
>   /branches/13/main/bridge_channel.c 420978 
>   /branches/13/main/bridge.c 420978 
>   /branches/13/channels/chan_pjsip.c 420978 
> 
> Diff: https://reviewboard.asterisk.org/r/3906/diff/
> 
> 
> Testing
> -------
> 
> Performed blind SIP transfers (REFER) and the call still passes media.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140819/d069ff71/attachment.html>