[asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3923/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

This allows the callerid parsing function to handle malformed input strings and strings containing escaped and unescaped double quotes. This also adds a unittest to cover many of the cases where the parsing algorithm previously failed.


Diffs
-----

  branches/1.8/tests/test_callerid.c PRE-CREATION 
  branches/1.8/res/res_agi.c 421326 
  branches/1.8/main/privacy.c 421326 
  branches/1.8/main/manager.c 421326 
  branches/1.8/main/callerid.c 421326 
  branches/1.8/include/asterisk/callerid.h 421326 
  branches/1.8/channels/chan_unistim.c 421326 
  branches/1.8/channels/chan_misdn.c 421326 
  branches/1.8/apps/app_voicemail.c 421326 
  branches/1.8/apps/app_dial.c 421326 

Diff: https://reviewboard.asterisk.org/r/3923/diff/


Testing
-------

Ran the unittest.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140819/3b441d1b/attachment.html>