[asterisk-dev] [Code Review] 3919: func_config: Change 'Not Found' message from ERROR to DEBUG

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3919/#review13105
-----------------------------------------------------------


Should be done for v1.8+.  That message is kind of over zealous being an ERROR.  We recently got rid of a similar over zealous WARNING message in URIENCODE/URIDECODE (See ASTERISK-23911).


branches/12/funcs/func_config.c
<https://reviewboard.asterisk.org/r/3919/#comment23554>

    Make this ast_debug(1, ...
    


- rmudgett


On Aug. 18, 2014, 11:46 a.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3919/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 11:46 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This one's been bugging me forever...
> 
> When you call the CONFIG dialplan function with the name of a variable that doesn't exist in the target context you get an ERROR.  This does nothing but clutter up the logs with messages that may be perfectly acceptable.  Just because a variable wasn't in the context doesn't mean it's an error.  Maybe it's optional or just needs to be defaulted or ignored.
> 
> This patch changes the log level from ERROR to DEBUG.  If a dialplan developer wants to debug their dialplan they still can.
> 
> 
> Diffs
> -----
> 
>   branches/12/funcs/func_config.c 421326 
> 
> Diff: https://reviewboard.asterisk.org/r/3919/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140818/f9112a1c/attachment-0001.html>