[asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

[Jonathan Rose]

> On Aug. 18, 2014, 9:24 a.m., Joshua Colp wrote:
> > /branches/12/res/res_stasis.c, lines 1330-1333
> > <https://reviewboard.asterisk.org/r/3917/diff/1/?file=66549#file66549line1330>
> >
> >     Add a comment explaining why this is being done.

Honestly, I don't believe this is necessary and as far as I can tell the only real purpose of doing this is to free up these resources prior to doing an operation that will lock the channel.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3917/#review13095
-----------------------------------------------------------


On Aug. 15, 2014, 10:53 a.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3917/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2014, 10:53 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24043
>     https://issues.asterisk.org/jira/browse/ASTERISK-24043
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Steps for reproduction:
> 
> * one extension in dial plan
> [default]
> exten => 1000,1,NoOp(Show me something running in verbosity 3 please)
> 
> * Start a websocket listening for a stasis application
> I use the websocket echo test to listen for application 'hello'
> 
> * Use the command POST /channels to call an endpoint and put it into stasis
> I used the args endpoint='SIP/1601', app='hello', channelID='test'
> 
> * Use the POST /channels/{channelID}/continue command to make the channel
> continue into the PBX I used the args channelID='test', context='default',
> extension='1000', priority=1
> 
> 
> Expectations:
> * The channel should leave stasis and start a new life in the PBX. Or to
> simplify, I should see a StasisEnd event on the websocket and I should see
> extension 1000 executing on the SIP/1601-xxxxxxxx channel since I run at
> verbosity 3.
> 
> Actual results prior to the patch:
> * StasisEnd is received, but the channel never enters the PBX and I don't
> see my NoOp application being ran.
> 
> The patch solves this problem by calling ast_pbx_run_args on the channel
> before it would leave the stasis_app_exec function when there isn't a PBX
> running on the channel and when the channel isn't hung up.
> 
> Patch: stasis-continue.diff submitted by Krandon Bruze
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_stasis.c 421079 
> 
> Diff: https://reviewboard.asterisk.org/r/3917/diff/
> 
> 
> Testing
> -------
> 
> Ran through reproduction with and without patch to confirm that the issue existed and that the patch fixes the issue.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140818/fa78d3cc/attachment.html>