[asterisk-dev] [Code Review] 3912: Fix ASTERISK-24032.

cloos reviewboard at asterisk.org
Thu Aug 14 17:04:49 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3912/
-----------------------------------------------------------

(Updated Aug. 14, 2014, 5:04 p.m.)


Review request for Asterisk Developers.


Changes
-------

Filled in branch/bugs fields


Bugs: ASTERISK-24032
    https://issues.asterisk.org/jira/browse/ASTERISK-24032


Repository: Asterisk


Description
-------

Fix for ASTERISK-24032.

The jira also has patches for each of the 1.8 .. 13 branches.

To deal with instances of gcc which are patched to define _FORTIFY_SOURCE internally, the convention is to use -U_FORTIFY_SOURCE before -D_FORTIFY_SOURCE, to avoid the redefined warnings.

So this is essentially:

   s/-D_FORTIFY_SOURCE/-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE/g

in configure.ac.

The patch does not include regenerating configure, in case of autoconf version differences.


Diffs
-----

  trunk/configure.ac 420991 

Diff: https://reviewboard.asterisk.org/r/3912/diff/


Testing
-------

./bootstrap.sh; ./configure; make

No warnings were generated.


Thanks,

cloos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140814/a2d35429/attachment.html>


More information about the asterisk-dev mailing list