[asterisk-dev] [Code Review] 3910: Fix test failures introduced by 420934
Jonathan Rose
reviewboard at asterisk.org
Thu Aug 14 13:28:59 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3910/
-----------------------------------------------------------
(Updated Aug. 14, 2014, 1:28 p.m.)
Review request for Asterisk Developers, Matt Jordan and rmudgett.
Changes
-------
Oops, copied the wrong link.
Bugs: ASTERISK-24027
https://issues.asterisk.org/jira/browse/ASTERISK-24027
Repository: Asterisk
Description
-------
r420934 changed ast_channel_is_leaving bridge to not care about the unbridge flag (which is no longer a softhangup flag due to that causing the behavior noted in ASTERISK-24027). This patch makes it so that the unbridge flag is evaluated again since that caused an unexpected change in how media would be re-established when a bridge starts to get torn down on hangup.
Diffs
-----
/branches/12/main/channel.c 420934
Diff: https://reviewboard.asterisk.org/r/3910/diff/
Testing (updated)
-------
Ran the failing tests from https://bamboo.asterisk.org/bamboo/browse/AST-ATSF-C632TE-336. I couldn't get all of them to pass prior to r420934, but the ones that I could run successfully were confirmed broken by r420934 and fixed by this patch.
Thanks,
Jonathan Rose
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140814/468eb001/attachment.html>
More information about the asterisk-dev
mailing list