[asterisk-dev] [Code Review] 3902: logger: Don't store verbose-magic in the log files.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3902/#review13063
-----------------------------------------------------------


So, I'm not against pulling this back to 11, but the reason why I went with (what was, at the time) trunk-only was the small amount of extra processing that occurs in writing the information out to the log file.

I'm not sure that's a valid concern, but if it is... well, there we go.

If we don't care, I'm good with pulling this back to 11/12.

- Matt Jordan


On Aug. 11, 2014, 4:58 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3902/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 4:58 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In r399267, the verbose2magic stuff was edited. This time it results
> in magic characters in the log files for multiline messages.
> 
> In trunk (and 13) this was fixed by the "stripping" of those
> characters from multiline messages (in r414798).
> 
> This is a backport of that fix to 11.
> The change from https://reviewboard.asterisk.org/r/3901/ is also
> included.
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/logger.c 420654 
> 
> Diff: https://reviewboard.asterisk.org/r/3902/diff/
> 
> 
> Testing
> -------
> 
> Tested simultaneously with r3901.
> 
> (Red blobs will be gone in both.)
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140811/a0436aa6/attachment.html>