[asterisk-dev] [Code Review] 3892: Stasis: Ensure transfer messages follow validation rules

opticron reviewboard at asterisk.org
Thu Aug 7 14:57:47 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3892/
-----------------------------------------------------------

(Updated Aug. 7, 2014, 2:57 p.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Add missing NULL-check.


Repository: Asterisk


Description
-------

This makes Stasis() event generation for transfer messages follow validation rules. Currently, ast_json_null() is being used in place of omitting a key entirely which falls afoul of these validation rules.


Diffs (updated)
-----

  branches/12/main/stasis_bridges.c 420388 

Diff: https://reviewboard.asterisk.org/r/3892/diff/


Testing
-------

Ensured that the test which detected the validation failures now passes.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140807/6bfcf175/attachment.html>


More information about the asterisk-dev mailing list