[asterisk-dev] [Code Review] 3864: testsuite: Add basic ARI out of call messaging tests

Mark Michelson reviewboard at asterisk.org
Wed Aug 6 15:24:02 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3864/#review13041
-----------------------------------------------------------

Ship it!



/asterisk/trunk/tests/rest_api/message/message_modules.py
<https://reviewboard.asterisk.org/r/3864/#comment23473>

    passed = all(r[0] for r in result)
    
    This saves construction of a list and is, imo, more readable.


- Mark Michelson


On July 28, 2014, 2:19 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3864/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 2:19 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23692 and ASTERISK-23969
>     https://issues.asterisk.org/jira/browse/ASTERISK-23692
>     https://issues.asterisk.org/jira/browse/ASTERISK-23969
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds four tests for ARI out of call text messaging support. For the actual patch, see https://reviewboard.asterisk.org/r/3726.
> 
> The tests cover:
>  - message/endpoint/recv - receiving a message while subscribed to an endpoint
>  - message/endpoint/send - sending a message to an endpoint
>  - message/technology/recv - receiving a message while subscribed to a technology
>  - message/technology/send - sending a message through the endpoints/ resource.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/message/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/technology/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/technology/send/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/technology/send/sipp/message_recv.xml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/technology/send/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/technology/recv/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/technology/recv/sipp/message.xml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/technology/recv/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/message_modules.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/endpoint/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/endpoint/send/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/endpoint/send/sipp/message_recv.xml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/endpoint/send/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/endpoint/recv/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/endpoint/recv/sipp/message.xml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/message/endpoint/recv/configs/ast1/pjsip.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3864/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140806/85e4804f/attachment.html>


More information about the asterisk-dev mailing list