[asterisk-dev] [Code Review] 3856: Fix Dynamic IAX2 Registrations From Failing Or Not Retrying After Temporary DNS Failure

Michael Young reviewboard at asterisk.org
Wed Aug 6 13:38:00 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3856/
-----------------------------------------------------------

(Updated Aug. 6, 2014, 2:38 p.m.)


Review request for Asterisk Developers.


Changes
-------

This patch addresses Josh's comments.


Bugs: ASTERISK-23767
    https://issues.asterisk.org/jira/browse/ASTERISK-23767


Repository: Asterisk


Description
-------

The reporter on the issue found some issues when upgrading from version 10 to 11 on 55 hosts.

Two situations that can occur with dynamic registrations.

1.  With dnsmgr disabled, if the host is not resolvable we are not trying to resolve the host again when it is time to attempt to register again.
2.  With dnsmgr enabled, when the host is temporarily not resolvable the address is set to 0.0.0.0:0 and then when the host is resolvable the port is not being restored and stays set to 0.

This patch resolves these two issues.


Diffs (updated)
-----

  /branches/11/channels/chan_iax2.c 420257 

Diff: https://reviewboard.asterisk.org/r/3856/diff/


Testing
-------

This was tested on a test machine.

The reporter of the issue also tested this and has confirmed that it solves both issues.


Thanks,

Michael Young

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140806/27efc155/attachment.html>


More information about the asterisk-dev mailing list