[asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13027
-----------------------------------------------------------



/trunk/res/res_pjsip_outbound_publish.c
<https://reviewboard.asterisk.org/r/3780/#comment23457>

    This feels like another implementation of string fields where the allocation is embedded in the struct. Is there a reason these values need to be a part of the same allocation?



/trunk/res/res_pjsip_outbound_publish.c
<https://reviewboard.asterisk.org/r/3780/#comment23455>

    Red blob.



/trunk/res/res_pjsip_publish_asterisk.c
<https://reviewboard.asterisk.org/r/3780/#comment23450>

    Documentation seems to alternate on whether this module is inbound-only or inbound/outbound.



/trunk/res/res_pjsip_publish_asterisk.c
<https://reviewboard.asterisk.org/r/3780/#comment23451>

    If the subscription fails, you have a leaked reference to datastore here.



/trunk/res/res_pjsip_publish_asterisk.c
<https://reviewboard.asterisk.org/r/3780/#comment23452>

    This will also leak on subscription failure.



/trunk/res/res_pjsip_publish_asterisk.c
<https://reviewboard.asterisk.org/r/3780/#comment23453>

    cached could be NULL.



/trunk/res/res_pjsip_publish_asterisk.c
<https://reviewboard.asterisk.org/r/3780/#comment23454>

    cached could be NULL.



/trunk/res/res_pjsip_pubsub.c
<https://reviewboard.asterisk.org/r/3780/#comment23446>

    This also appears to be a struct-embedded implementation of string fields.


- opticron


On Aug. 5, 2014, 12:37 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3780/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 12:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds two PJSIP modules which add outbound PUBLISH support and an 'asterisk' event type.
> 
> The res_pjsip_outbound_publish module is a common module which provides basic logic for setting up outbound PUBLISH clients, handling authentication requests, handling configuration, and lifetime. Extra modules implement specific event types which are registered with res_pjsip_outbound_publish. Since it takes care of configuration when an outbound PUBLISH is configured extra configuration can be passed to the event type implementation to further configure itself.
> 
> The res_pjsip_publish_asterisk module implements inbound and outbound support for an 'asterisk' event type. This event type conveys device and mailbox state between Asterisk instances using a JSON content body. As internal device or mailbox state changes the module sends a PUBLISH message to other configured instances. When a PUBLISH is received the contents are examined and a device or mailbox state change queued up within Asterisk. To restrict what is sent and received filtering is available using regular expressions which can reduce SIP traffic.
> 
> A wiki page is available at https://wiki.asterisk.org/wiki/display/~jcolp/Exchanging+Device+and+Mailbox+State+Using+PJSIP which has some configuration details with some examples. This should also be reviewed.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip_pubsub.exports.in 420047 
>   /trunk/res/res_pjsip_pubsub.c 420047 
>   /trunk/res/res_pjsip_publish_asterisk.c PRE-CREATION 
>   /trunk/res/res_pjsip_outbound_publish.exports.in PRE-CREATION 
>   /trunk/res/res_pjsip_outbound_publish.c PRE-CREATION 
>   /trunk/include/asterisk/res_pjsip_pubsub.h 420047 
>   /trunk/include/asterisk/res_pjsip_outbound_publish.h PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3780/diff/
> 
> 
> Testing
> -------
> 
> Set up two Asterisk instances, configured both sides to publish to eachother, made calls and manipulated voicemail. Watched PUBLISH messages go between them and state change.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140806/c6bc0b9e/attachment-0001.html>