[asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI

opticron reviewboard at asterisk.org
Wed Aug 6 09:18:12 CDT 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3883/#review13021
-----------------------------------------------------------


As a side note, all these IntegrityCheck classes are nearly identical except for degenerate cases where sending the AMI message is not necessary or you only expect one version of the notify. They are also highly similar to the IntegrityCheck classes used in your three other RLS test reviews. If you choose not to move them into a common class, you can probably assume that any findings on the IntegrityCheck class apply across all four reviews for all tests in those reviews.


/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_alice/full_state.py
<https://reviewboard.asterisk.org/r/3883/#comment23442>

    This is missing a docstring.


- opticron


On Aug. 1, 2014, 5:46 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3883/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 5:46 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Bugs: ASTERISK-23872
>     https://issues.asterisk.org/jira/browse/ASTERISK-23872
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Similar to the MWI tests in https://reviewboard.asterisk.org/r/3875/
> 
> The main set of tests follows operations against the following list setup:
> 
> subscription to mail_list
> mail_list: carol (MWI), mail_sublist (list)
> mail_sublist: alice (MWI), bob (MWI)
> 
> This setup is tested against the following:
> 
> subscription_establishment: Uses sipp to check that a subscription can successfully be established (only evaluates SIP traffic to and from Asterisk, not concerned with NOTIFY contents)
> 
> initial_notify: Verifies that a NOTIFY is received after subscribing and that it contains all of the expected elements
> 
> full_state_alice: After receiving the initial notify, Alice's mailbox state is changed. The following NOTIFY is checked to confirm that it contains full state for all items in mail_list (which includes state information for mail_sublist items as well)
> 
> full_state_carol: As with full_state_alice, only Carol's mailbox state is changed instead.
> 
> partial_state_alice: As with full_state_alice, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include mail_sublist and mail_sublist should only include alice.
> 
> partial_state_carol: As with full_state_carol, only since full state information isn't set for the lists, we only want changed entries. In this case, the notify should only include carol and not the mail_sublist.
> 
> resubscribe_full_state: After the initial notify, The sipp client resubscribes to the list. We expect to receive full state information even though the individual lists are set to give partial state information on updates.
> 
> termation_full_state: After the initial notify, the sipp client terminates the subscription. We expect to receive full state information even though the individual lists are set to give partial state information on updates and also we expect the state of each list entry to be terminated since we are unsubscribing.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/termination.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/sipp/termination.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/subscription_establishment/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/sipp/resubscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/resubscribe.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/partial_state.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/partial_state.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/initial_notify/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/initial_notify/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/initial_notify/notify.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/initial_notify/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_carol/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_carol/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_carol/full_state.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_carol/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_alice/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_alice/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_alice/full_state.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_alice/configs/ast1/pjsip.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3883/diff/
> 
> 
> Testing
> -------
> 
> All tests were checked against the rls-rlmi branch to make sure they would run and produce the expected flow of SIP messages.  All tests had their expected RESOURCES lists changed to verify that if they differed from the contents of the NOTIFY in any way that the tests would fail.
> 
> MWI tests also check the contents of the headers specific to MWI to verify that actually have the Voice-Message and Messages-Waiting headers set to the expected values.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140806/43845044/attachment.html>

More information about the asterisk-dev mailing list