[asterisk-dev] [Code Review] 3884: testsuite: fail sipp test if sipp not installed

Scott Griepentrog reviewboard at asterisk.org
Tue Aug 5 16:53:56 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3884/
-----------------------------------------------------------

(Updated Aug. 5, 2014, 4:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 5341


Repository: testsuite


Description
-------

If sipp is not listed as a dependency, and isn't installed, the sipp test case would lock up the testsuite run trying to kill a nonexistant process.

This change raises an exception if the sipp isn't found when initializing the sipp test case to prevent this issue.

Also, I added the dependency to the test that I got stuck on.


Diffs
-----

  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/user_agent/test-config.yaml 5328 
  /asterisk/trunk/lib/python/asterisk/sipp.py 5328 

Diff: https://reviewboard.asterisk.org/r/3884/diff/


Testing
-------


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140805/2050f9a8/attachment-0001.html>


More information about the asterisk-dev mailing list