[asterisk-dev] [Code Review] 3863: testsuite: Add two tests for transmission of RTCP information to a HEP server

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3863/#review13000
-----------------------------------------------------------

Ship it!


Other than Scott's comment about the regexes and the nitpicks below, this looks good to go.


/asterisk/trunk/tests/hep/rtcp-receiver/test-config.yaml
<https://reviewboard.asterisk.org/r/3863/#comment23420>

    s/ :/:/



/asterisk/trunk/tests/hep/rtcp-sender/test-config.yaml
<https://reviewboard.asterisk.org/r/3863/#comment23421>

    s/ :/:/


- opticron


On July 27, 2014, 10:43 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3863/
> -----------------------------------------------------------
> 
> (Updated July 27, 2014, 10:43 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch adds two tests that cover transmitting RTCP information to a HEP server:
>  * rtcp-sender: One Asterisk instance dials another Asterisk instance. Audio is streamed from the first instance and echo'd back from the second to the first. This results in RTCP information from both instances being sent to a HEP server, where both sides are 'senders' and thus generate/receive SR packets.
>  * rtcp-receiver: One Asterisk instance dials another Asterisk instance. Audio is streamed from the first instance and absorbed by the second. This results in RTCP information from both instances being sent to a HEP server, where the first transmits SR packets and received RR packets and the second transmits RR packets and received SR packets.
> 
> The test does basic validation of the received HEP packets from both Asterisk instances.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/hep/tests.yaml 5254 
>   /asterisk/trunk/tests/hep/rtcp-sender/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast2/hep.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast1/hep.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast2/hep.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast1/hep.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/test-config.yaml 5254 
>   /asterisk/trunk/tests/hep/pjsip-ipv6/test-config.yaml 5254 
>   /asterisk/trunk/tests/hep/pjsip-auth/test-config.yaml 5254 
>   /asterisk/trunk/tests/hep/hep_capture_node.py 5254 
>   /asterisk/trunk/lib/python/asterisk/test_suite_utils.py 5254 
>   /asterisk/trunk/lib/python/asterisk/ari.py 5254 
> 
> Diff: https://reviewboard.asterisk.org/r/3863/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140805/a7434b69/attachment.html>