[asterisk-dev] [Code Review] 3889: format: Remove incorrectly assigned format compatibility bits for Opus and VP8.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3889/
-----------------------------------------------------------

(Updated Aug. 5, 2014, 12:36 p.m.)


Status
------

This change has been discarded.


Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

The format compatibility bits need to remain frozen to new codecs.  Otherwise, older channel drivers like chan_iax2 could attempt to negotiate them when they have no support for negotiating any of the format's other potential parameters.  In addition, the chan_iax2 format preference order values sent over the wire have no defined fixed value to represent Opus and VP8.


Diffs
-----

  /branches/12/main/format.c 420025 

Diff: https://reviewboard.asterisk.org/r/3889/diff/


Testing
-------

Compiles and code inspeciton.

See format.c:format_list_init() and format_pref.c:ast_codec_pref_convert().
The format_list container is used to generate the format_list_array which is then is used by chan_iax2 to determine the format index sent over the wire in IAX_IE_CODEC_PREFS.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140805/18ef86c8/attachment.html>