[asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3869/#review12996
-----------------------------------------------------------



/asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3869/#comment23414>

    You could just use Echo here



/asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast1/pjsip.conf
<https://reviewboard.asterisk.org/r/3869/#comment23413>

    Blob



/asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast1/pjsip.conf
<https://reviewboard.asterisk.org/r/3869/#comment23416>

    This looks a little odd. Just to double check... should the '@' sign be there?



/asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast2/pjsip.conf
<https://reviewboard.asterisk.org/r/3869/#comment23415>

    Blob



/asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/test-config.yaml
<https://reviewboard.asterisk.org/r/3869/#comment23412>

    Nitpick: 13.0.0


- Matt Jordan


On Aug. 3, 2014, 5:58 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3869/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2014, 5:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24115
>     https://issues.asterisk.org/jira/browse/ASTERISK-24115
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This change adds two things:
> 
> 1. The ability for an action to be configured for an AMI event handler. Right now two actions are supported: "none" and "stop". If the "stop" action is configured the test will be terminated when the minimum number of events is received.
> 
> 2. A test which establishes a relationship between two running Asterisk instances and publishes device state from one to the other. The test confirms that the second Asterisk receives all device state changes in the expected order.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 5316 
>   /asterisk/trunk/tests/channels/pjsip/publish/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/ami.py 5316 
> 
> Diff: https://reviewboard.asterisk.org/r/3869/diff/
> 
> 
> Testing
> -------
> 
> Executed test, it passes. Sabotaged test, it fails.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140805/997bf14c/attachment-0001.html>