[asterisk-dev] [Code Review] 3870: alembic: Adjust sippeers, queue_members, and voicemail_messages tables.

[rmudgett]

> On Aug. 4, 2014, 4:10 p.m., Mark Michelson wrote:
> > /branches/12/contrib/ast-db-manage/voicemail/versions/39428242f7f5_increase_recording_column_size.py, lines 36-37
> > <https://reviewboard.asterisk.org/r/3870/diff/1/?file=65734#file65734line36>
> >
> >     There is something just absolutely frightening about this. Can you add to your comment:
> >     
> >     1) why this is necessary
> >     2) a reference indicating that this is the correct way of doing this for MySQL
> >     3) some reassurance that this will not do something awful for other DBMSs.
> >     
> >     As it looks, every voicemail message is going to have 4GB set aside for it.

This is necessary because mysql will truncate recordings to about 4 seconds worth of audio as mysql limits a BLOB to only 64k.
For postgres, the backend did not output anything different.

This is the only parameter that LargeBinary is documented as accepting.
See LargeBinary http://docs.sqlalchemy.org/en/rel_0_9/core/types.html

I'll augment the comment.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3870/#review12974
-----------------------------------------------------------


On July 30, 2014, 9:52 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3870/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 9:52 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23825, ASTERISK-23847 and ASTERISK-23909
>     https://issues.asterisk.org/jira/browse/ASTERISK-23825
>     https://issues.asterisk.org/jira/browse/ASTERISK-23847
>     https://issues.asterisk.org/jira/browse/ASTERISK-23909
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Increased the sippeers useragent max string size to 255.
> 
> * Changed the queue_members uniqueid to an auto incremented integer instead of a string.
> 
> * Increased the voicemail_messages BLOB size to LONGBLOB on mysql.
> 
> * Fixed the add_tables_for_pjsip config change version downgrade actions to drop a table it created.
> 
> * Adjusted the sample alembic.ini files cdr.ini.sample, config.ini.sample, and voicemail.ini.sample to give a mysql and postgres sqlalchemy.url lines.
> 
> 
> Diffs
> -----
> 
>   /branches/12/contrib/ast-db-manage/voicemail/versions/39428242f7f5_increase_recording_column_size.py PRE-CREATION 
>   /branches/12/contrib/ast-db-manage/voicemail.ini.sample 419804 
>   /branches/12/contrib/ast-db-manage/config/versions/5139253c0423_make_q_member_uniqueid_autoinc.py PRE-CREATION 
>   /branches/12/contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py 419804 
>   /branches/12/contrib/ast-db-manage/config/versions/1758e8bbf6b_increase_useragent_column_size.py PRE-CREATION 
>   /branches/12/contrib/ast-db-manage/config.ini.sample 419804 
>   /branches/12/contrib/ast-db-manage/cdr.ini.sample 419804 
> 
> Diff: https://reviewboard.asterisk.org/r/3870/diff/
> 
> 
> Testing
> -------
> 
> The alembic table adjustments work in the upgrade and downgrade modes for mysql and postgres.
> 
> The queue_members change does give a postgres warning message from the postgres alembic backend about a mysql only kind of change.  The warning is benign and can be ignored as it is an alembic only warning.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140804/a5356067/attachment.html>