[asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

[Joshua Colp]

Olle E. Johansson wrote:
>
> On 31 Jul 2014, at 17:28, Joshua Colp <reviewboard at asterisk.org
> <mailto:reviewboard at asterisk.org>> wrote:
>
>> This adds two PJSIP modules which add outbound PUBLISH support and an 'asterisk' event type.
>>
> I don't think it's a good idea to mix different events in one event tag.
> Will make it hard to handle in proxys and stuff. We will have to
> parse the json to find out what it is and what to do with it. It's not a
> good solution.
>
> Use asterisk-mwi and asterisk-devstate instead.

I have incorporated this feedback and posted a new review for both the 
implementation and the test for device state.

Cheers,

-- 
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org