[asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

rnewton reviewboard at asterisk.org
Fri Aug 1 13:17:59 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3854/
-----------------------------------------------------------

(Updated Aug. 1, 2014, 6:17 p.m.)


Review request for Asterisk Developers.


Changes
-------

In regards to a conversation with M.Jordan, I removed text about variable inheritance as there is no need to be overly explicit even if the Set application help text already is. Variable inheritance is more general and is documented on the wiki already.


Bugs: ASTERISK-21178
    https://issues.asterisk.org/jira/browse/ASTERISK-21178


Repository: Asterisk


Description
-------

The documentation wasn't clear that AMI Getvar and Setvar could accept function calls.

This is a slight modification to improve clarity.


Diffs (updated)
-----

  /branches/1.8/main/manager.c 419821 

Diff: https://reviewboard.asterisk.org/r/3854/diff/


Testing
-------

Once finalized I'll build in dev-mode with it to make sure I didn't screw up any tags.

7/30/14 @ 5:52PM CDT - Builds with no issues in dev-mode.


Thanks,

rnewton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140801/c11f67c5/attachment.html>


More information about the asterisk-dev mailing list