[asterisk-dev] [Code Review] 3491: res_pjsip: Allow cipher to be specified by name

Sean Bright reviewboard at asterisk.org
Tue Apr 29 15:17:18 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3491/#review11787
-----------------------------------------------------------

Ship it!


Ship It!

- Sean Bright


On April 29, 2014, 3:21 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3491/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 3:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23498
>     https://issues.asterisk.org/jira/browse/ASTERISK-23498
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The "cipher" option in res_pjsip currently requires that the cipher be specified using the OpenSSL identifier instead of the name. This change makes it so that the name is turned into the respective identifier, allowing the cipher option to accept the name instead!
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/config_transport.c 413101 
> 
> Diff: https://reviewboard.asterisk.org/r/3491/diff/
> 
> 
> Testing
> -------
> 
> Before patch:
> 
> Configured cipher using name, received "Unsupported" log message.
> 
> After patch:
> 
> Configured cipher using name, received no log message.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140429/d5d87731/attachment.html>


More information about the asterisk-dev mailing list