[asterisk-dev] [Code Review] 3417: Add AMI events for all device state and presence state changes

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3417/#review11747
-----------------------------------------------------------

Ship it!



/trunk/res/res_manager_devicestate.c
<https://reviewboard.asterisk.org/r/3417/#comment21555>

    Could just combine these lines: topic_forward = stasis_forward_cancel..



/trunk/res/res_manager_presencestate.c
<https://reviewboard.asterisk.org/r/3417/#comment21554>

    Same here.


- Corey Farrell


On April 23, 2014, 7:02 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3417/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 7:02 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> AMI does not emit events when device state or presence state changes. The closest things that exist currently are the ExtenstionStatus and PresenceStatus events, which inform about device state and presence state events as they pertain to hints in the dialplan. These new events are raised for every device state change or presence state change in Asterisk.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_manager_presencestate.c PRE-CREATION 
>   /trunk/res/res_manager_devicestate.c PRE-CREATION 
>   /trunk/main/presencestate.c 412583 
>   /trunk/main/devicestate.c 412583 
> 
> Diff: https://reviewboard.asterisk.org/r/3417/diff/
> 
> 
> Testing
> -------
> 
> See /r/3418
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140425/53c06e6e/attachment.html>