[asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3420/#review11743
-----------------------------------------------------------



./asterisk/trunk/lib/python/asterisk/pluggable_modules.py
<https://reviewboard.asterisk.org/r/3420/#comment21550>

    Is each configuration meant to run multiple call file scenarios at a time? Based on the rest of the code it all looks setup to only do one. If that's the case the "for loop" is not needed.



./asterisk/trunk/lib/python/asterisk/pluggable_modules.py
<https://reviewboard.asterisk.org/r/3420/#comment21544>

    This still only sets a single call file params.  If multiple call-file-params are configured then this will only set the last value.  If it is meant to only run a single test then remove the loop otherwise you'll need to find a way to store multiple configured call file params and have them looked back up on the user event.



./asterisk/trunk/lib/python/asterisk/pluggable_modules.py
<https://reviewboard.asterisk.org/r/3420/#comment21545>

    You only need to register the observer once.



./asterisk/trunk/lib/python/asterisk/pluggable_modules.py
<https://reviewboard.asterisk.org/r/3420/#comment21546>

    Again, this works because you are currently running one test, but if multiple configurations are specified then this will only use the index of the last test.



./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/retries_alwaysdelete.py
<https://reviewboard.asterisk.org/r/3420/#comment21548>

    Is there a reason the handler(s) have to be "called later"?


- Kevin Harwell


On April 24, 2014, 5:13 p.m., Scott Emidy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3420/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 5:13 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23218
>     https://issues.asterisk.org/jira/browse/ASTERISK-23218
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> These tests involved checking that call files max retries are functioning as planned through four tests:
> 
> 1) The first test (call_file_retries_fail) required that the call file originates a local channel to a dialplan extension that will always fail, and checks to make sure that it ran through all of its max retries.
> 
> 2) The second test (call_file_retries_success) involves a call file that originates a local channel that will fail once, but then is answered before it hits its max retries.
> 
> 3) The third test (call_file_retries_alwaysdelete) consists of checking whether or not the call file was deleted from the [astspooldir]'s outgoing folder when the alwaysdelete option is set to 'no'.
> 
> 4) The fourth and final test (call_file_retries_archive) consists of checking whether or not the call file was placed in [astspooldir]'s outgoing_done folder when archive is set to 'yes'.
> 
> 
> Diffs
> -----
> 
>   ./asterisk/trunk/tests/pbx/tests.yaml 4983 
>   ./asterisk/trunk/tests/pbx/call_file_retries_success/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_success/retries_success.py PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_success/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_fail/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_fail/retries_fail.py PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_fail/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_archive/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_archive/retries_archive.py PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_archive/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/retries_alwaysdelete.py PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4983 
> 
> Diff: https://reviewboard.asterisk.org/r/3420/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Emidy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140425/9fd6e898/attachment.html>