[asterisk-dev] [Code Review] 3476: Memory Pre- and Post-Test Condition

[Benjamin Keith Ford]

> On April 24, 2014, 10:46 p.m., Mark Michelson wrote:
> > I suggest writing a sample yaml file that illustrates how this is intended to be used and explains what the default values are for the various configuration options.

I'll start working on that. In the mean time, I'm going to go ahead and upload all the revisions just in case any more findings pop up.


> On April 24, 2014, 10:46 p.m., Mark Michelson wrote:
> > ./asterisk/trunk/lib/python/asterisk/test_conditions.py, lines 122-123
> > <https://reviewboard.asterisk.org/r/3476/diff/1/?file=57814#file57814line122>
> >
> >     Any particular reason you switched this away from raising an exception?

This was changed by Matt when he found that post conditions were not registering properly. I'm assuming this change was made because it's not a ValueError if a pre condition isn't found at all, since a ValueError should be raised if the right type is found. If nothing is found at all, than a log error or something similar would be more appropriate.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3476/#review11734
-----------------------------------------------------------


On April 25, 2014, 2:46 p.m., Benjamin Keith Ford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3476/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 2:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-18429
>     https://issues.asterisk.org/jira/browse/ASTERISK-18429
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This testcondition can be enabled for any test using the keyword 'memory' under testconditions. The purpose of this testcondition is to check the memory allocated before and after the test, and make sure they are within a certain range. If the test wants to look at something specific (such as channel.c), then each allocation that you want to look at can also be specified in under 'allocations'. If both the global memory and individual allocations are to be checked by the test, that option can be enabled by setting 'both' to value True.
> 
> 
> Diffs
> -----
> 
>   ./asterisk/trunk/test-config.yaml 4944 
>   ./asterisk/trunk/lib/python/asterisk/test_conditions.py 4944 
>   ./asterisk/trunk/lib/python/asterisk/test_case.py 4944 
>   ./asterisk/trunk/lib/python/asterisk/memory_test_condition.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3476/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Keith Ford
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140425/d6e442b0/attachment-0001.html>