[asterisk-dev] [Code Review] 3444: Testsuite: PJSIP Callee Initiated Nominal Blind Transfers

Benjamin Keith Ford reviewboard at asterisk.org
Thu Apr 24 14:33:26 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3444/#review11731
-----------------------------------------------------------


Are the [general] and [globals] contexts necessary in your dialplan since they have no extensions under them?

- Benjamin Keith Ford


On April 17, 2014, 4:10 p.m., Scott Emidy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3444/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 4:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23447
>     https://issues.asterisk.org/jira/browse/ASTERISK-23447
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> These three tests involve using PJSIP in order to execute callee initiated blind transfers.
> 
> Also all three of these tests fail due to the unresolved issues ASTERISK-23501 and ASTERISK-23502.
> 
> These tests required a few aspects in each test such as the SIPREFERTOHDR, SIPREFERREDBYHDR, SIPTRANSFER, SIPREFERRINGCONTEXT, BLINDTRANSFER Event, TRANSFER_CONTEXT that comes into play in the second iterations, and Referred-By header. MusicOnHOldStart and MusicOnHoldStop were only required for the callee_hold test.
> 
> The three tests were:
> 1) Callee initiated transfer with direct media (callee_direct_media) - This consists of direct media being initiated between the endpoints before and after the transfer.
> 2) Callee initiated transfer with hold (callee_hold) - This consists of a blind transfer that puts the caller on hold before they are transferred.
> 3) Callee initiated transfer with REFER only (callee_only_refer) - This consists of no hold or media just a basic REFER. Also John Bigelow made changes to the pjsua_mod.py to be able to associate pjsua accounts with a specific pjsua transport.
> 
> 
> Diffs
> -----
> 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/transfer.py PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/configs/ast1/pjsip.conf PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/sipp/charlie.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/sipp/bob.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/sipp/alice.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/configs/ast1/pjsip.conf PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/charlie.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/bob.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/alice.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/configs/ast1/pjsip.conf PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/tests.yaml 4957 
>   ./asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4957 
> 
> Diff: https://reviewboard.asterisk.org/r/3444/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Emidy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140424/dbb30173/attachment.html>


More information about the asterisk-dev mailing list