[asterisk-dev] [Code Review] 3475: pjsip realtime: increase the size of some columns

Joshua Colp reviewboard at asterisk.org
Wed Apr 23 14:45:30 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3475/#review11724
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On April 23, 2014, 7:28 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3475/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 7:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23639
>     https://issues.asterisk.org/jira/browse/ASTERISK-23639
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The string lengths on certain columns created through alembic for PJSIP were too short. For instance, columns containing URIs are currently set to 40 characters, but this can be too small and result in truncated values.  Added an alembic migration script that increases the size of these columns and a few others to 255.
> 
> 
> Diffs
> -----
> 
>   branches/12/contrib/ast-db-manage/config/versions/e96a0b8071c_increase_pjsip_column_size.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3475/diff/
> 
> 
> Testing
> -------
> 
> Tested against both postgres and mysql databases.  Also made sure an offline sql script could be generated without error.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140423/654163c1/attachment-0001.html>


More information about the asterisk-dev mailing list