[asterisk-dev] [Code Review] 3337: Code for DTLS retransmission

[Nitesh Bansal]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3337/
-----------------------------------------------------------

(Updated April 22, 2014, 8:10 a.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed the following issue:
1. Wrong order of operations while dereferencing rtp and unlocking the mutex
2. Removed the unnecessary check for RTP being NULL, as it is already checked in the beginning


Repository: Asterisk


Description
-------

This patch adds the code to do the DTLS retransmissions in Asterisk.


Diffs (updated)
-----

  http://svn.asterisk.org/svn/asterisk/branches/11/res/res_rtp_asterisk.c 412875 

Diff: https://reviewboard.asterisk.org/r/3337/diff/


Testing
-------

I tested this with a basic SIPP script, which fakes a DTLS INVITE.
Asterisk thinks that it is a DTLS call and inititates the DTLS handshake. SIPP doesn't respond to DTLS handshake, which causes the DTLS timeout and DTLS retransmission takes place.


Thanks,

Nitesh Bansal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140422/40bb4605/attachment-0001.html>