[asterisk-dev] [Code Review] 3449: Testsuite: PJSIPQualify AMI Action Test

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3449/#review11698
-----------------------------------------------------------



./asterisk/trunk/tests/channels/pjsip/ami/pjsip_qualify/AMISendTest.py
<https://reviewboard.asterisk.org/r/3449/#comment21466>

    Update the copyright date to be 2013-2014



./asterisk/trunk/tests/channels/pjsip/ami/pjsip_qualify/AMISendTest.py
<https://reviewboard.asterisk.org/r/3449/#comment21467>

    This test is a bit weird because the two scenarios don't really seem related to each other. User1 registers a dynamic contact at port 5061, but then you end up sending the OPTIONs request to the permanent contact that was established in pjsip.conf at port 5062.
    
    I recommend getting rid of the registration scenario entirely. This way, the test is  much simpler and concentrates more on the functionality that is under test. In your ami_connect method, start the options.xml scenario and then run the AMI action.


- Mark Michelson


On April 15, 2014, 8:09 p.m., Scott Emidy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3449/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 8:09 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23534
>     https://issues.asterisk.org/jira/browse/ASTERISK-23534
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test registers an endpoint with Asterisk using a SIPp scenario, receives a 200 OK, sends the PJSIPQualify Action to Asterisk, the endpoint receives an options request, then finally returns a 200 OK.
> 
> 
> Diffs
> -----
> 
>   ./asterisk/trunk/tests/channels/pjsip/ami/tests.yaml 4957 
>   ./asterisk/trunk/tests/channels/pjsip/ami/pjsip_qualify/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/ami/pjsip_qualify/sipp/qualify.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/ami/pjsip_qualify/sipp/options.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/ami/pjsip_qualify/configs/ast1/pjsip.conf PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/ami/pjsip_qualify/AMISendTest.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3449/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Emidy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140418/e9d84ede/attachment.html>